New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Contracts] Update dependency to use symfony/service-contracts #65
Conversation
…ding clashes with Symfony 4.3
@wbrinkman @nicolas-grekas Any news here? |
I just saw this in the Symfony Demo app. Looking forward to the merge and new version release! Thank you.
|
Any update on this? |
@weaverryan Could you please press "Merge pull request" button and make a new release? We already have 3 approvals in this PR. |
I love how webpack encore improved my frontend workflow in so many ways. But the wait for this PR is very worrisome. It is a very basic commit that keep this bundle in sync with the Symfony ecosystem that it's supposed to be part of. |
Anybody else have merge & versioning rights that could possibly push this through the finishing line pls? |
@weaverryan @nicolas-grekas @fabpot Please help someone to press Merge button in this PR, which is ready for a month, has 3 approvals and have just been ignored one more time during creating a new release 5 hours ago. |
Sorry - will merge tonight. This bundle is my responsibility and I’ve been a bit busy - apologies for the inconvenience! |
Thank you @wbrinkman! And sorry again for the delay - thanks for everyone's patience! |
…s (wbrinkman) This PR was merged into the master branch. Discussion ---------- [Contracts] Update dependency to use symfony/service-contracts Updated requirement symfony/contracts to symfony/service-contracts so having this bundle in a Symfony 4.3 installation does not generate ambiguous classes with an optimized composer autoloader. Fixes #64 Commits ------- 2ec86a5 Update dependency to use symfony/service-contracts to prevent autoloading clashes with Symfony 4.3
Thank you @weaverryan 👍 |
Updated requirement symfony/contracts to symfony/service-contracts so having this bundle in a Symfony 4.3 installation does not generate ambiguous classes with an optimized composer autoloader.
Fixes #64